nsmithuk / local-kms

A mock version of AWS' Key Management Service, for local development and testing.
MIT License
198 stars 34 forks source link

Adds GetKeyPolicy and support for Policy in CreateKey. #10

Closed wesselvdv closed 5 years ago

wesselvdv commented 5 years ago

Fixes #9, it now successfully works in Terraform.

nsmithuk commented 5 years ago

Hi @wesselvdv

Thank you for doing this!

I've made a small amend to my local copy of your feature/get-key-policy branch. Please can you check what I've done still meets your requirements. If so, please merge/rebase it into your branch, and I'll merge your PR.

In short I've made Policy an attribute of Key rather than KeyMetadata. This keeps Local KMS's KeyMetadata type inline with AWS' kms.KeyMetadata type.

wesselvdv commented 5 years ago

I've merged your changes back into my branch!