search

nsmithuk / local-kms

A mock version of AWS' Key Management Service, for local development and testing.
MIT License
198 stars 34 forks source link

Inomurko/fix secp256k1 #38

Open InoMurko opened 2 years ago

InoMurko commented 2 years ago

Noticed an incomplete support for secp256k1: https://github.com/nsmithuk/local-kms/issues/36

nsmithuk commented 2 years ago

Hi @InoMurko. Thank you for submitting this.

Please can I start by asking what is the benefit of using ethereum/go-ethereum is over btcsuite/btcd?

InoMurko commented 2 years ago

@nsmithuk true, not particular reason. I extracted the private key import functions that were needed and removed go-ethereum crypto.

nsmithuk commented 2 years ago

Hi @InoMurko. Is the reason for adding the Hex format for secp256k1 keys so that they're distinguishable from secp256r1 keys? i.e. is the view that secp256k1 is Hex and secp256r1 is PEM?

lukaskiss222 commented 1 year ago

When will it be fixed?

InoMurko commented 1 year ago

Hi @InoMurko. Is the reason for adding the Hex format for secp256k1 keys so that they're distinguishable from secp256r1 keys? i.e. is the view that secp256k1 is Hex and secp256r1 is PEM?

hex is prefered because for local dev environment, where one uses hardhat or similar - the private keys that are deterministically created are provided hex, so the import is easier

waynenilsen commented 11 months ago

I'm using their fork for the same reason (same requirement).

@nsmithuk is it work asking the author to rebase? Would you consider merging something like this?

Hex is standard format for private keys of this nature.

Their fork works great for what I need it to do.