search

nsomar / OAStackView

Porting UIStackView to iOS 7+
MIT License
2.14k stars 191 forks source link

iOS9: UIStackView is horizontal by default, OAStackView is vertical #51

Closed delebedev closed 8 years ago

delebedev commented 9 years ago

Looks like breaking change, but if we want smooth transition from OA to UI version they should be the same.

ghost commented 8 years ago

Any update on this? Still noticing it remains the same.

delebedev commented 8 years ago

@oarrabi need your input here, issue is really straightforward but will require Major version bump since it will break all the apps

harlanhaskins commented 8 years ago

I really don't like changing the default axis. But we have to.

delebedev commented 8 years ago

@harlanhaskins thanks for your input, looks like good change for 1.0 release! :trollface:

delebedev commented 8 years ago

Fixed in 1.0.0 version

coridn commented 8 years ago

As an FYI, the header for OAStackView still says the default is Vertical.

Through me for a loop when I upgraded my pods and none of my views worked anymore. May want to consider updating that as well.

delebedev commented 8 years ago

@coridn nice catch, fixed here https://github.com/oarrabi/OAStackView/commit/c606348cbf7f4dc40f87e841462504cc0c4e6cb1