nsomar / OAStackView

Porting UIStackView to iOS 7+
MIT License
2.14k stars 191 forks source link

Fix bug where OAStackView.axis didn't actually default to vertical. #80

Closed GriffinSchneider closed 8 years ago

GriffinSchneider commented 8 years ago

OAStackView.axis has a comment saying //Default is Vertical, but the default was actually horizontal. This pullreq adds a test for the default axis, and makes it actually default to vertical.

delebedev commented 8 years ago

Hi @GriffinSchneider sorry for confusion. Actually horizontal is correct. Even though UIStackView does not say it explicitly, UILayoutConstraintAxisHorizontal has value of 0 which makes it default. Please see https://github.com/oarrabi/OAStackView/issues/51 for more details