nspcc-dev / gh-push-to-neofs

GitHub action to push things into NeoFS
MIT License
7 stars 2 forks source link

`NEOFS_HTTP_GATE` parameter not clear #11

Open carpawell opened 11 months ago

carpawell commented 11 months ago

Problem

This parameter confuses me as a regular user. Usually, I read the parameters of any function/action as a part of its code: if it needs it, it should use it and I can understand it better. How http gate is used in this action?

Context

Why do we need this parameter? It is a http gate that should be connected to a storage node used for object download. However, it is not used for object downloading, is not validated, and is not checked for an http-SN relation. It also does not simplify action usability: a user has to figure out the correct http gateway himself anyway, no matter if it happens after the objects download or before CI workflow creation. If he knows it, he can use it. If he does not need it, he doesn't want to find it (hehe, neofs does not live for browsers only), he should be able to omit it (once again, http is not a required thing for the action literally named "push to neofs").

roman-khimov commented 4 months ago

Related to #18.