search

nspcc-dev / gh-push-to-neofs

GitHub action to push things into NeoFS
MIT License
7 stars 2 forks source link

Added replace_objects and replace_container_contents options #16

Closed MaxGelbakhiani closed 6 months ago

MaxGelbakhiani commented 6 months ago

Fixes #2 and #15

roman-khimov commented 6 months ago

Please also mention #15, btw.

MaxGelbakhiani commented 6 months ago

@roman-khimov How do we want the action to behave by default with these flags? Right now the default behavior is to upload (old behavior) without deleting objects.

roman-khimov commented 6 months ago

The least surprising is likely REPLACE_OBJECTS=True. Can be the default.

MaxGelbakhiani commented 6 months ago

I don't see a test that does REPLACE_CONTAINER_CONTENTS.

Do we have a separate container tied to the current Github repo? Is it safe to rewrite the entire container?

roman-khimov commented 6 months ago

It's for tests only, it can be rewritten in any way.

MaxGelbakhiani commented 6 months ago

It's for tests only, it can be rewritten in any way.

I've pushed tests with container contents replacement. The last 25 minutes test run is the one with deleting all the old objects in the container.