search

nspcc-dev / locode-db

Source of UN/LOCODE database generated by NeoFS CLI.
MIT License
3 stars 6 forks source link

Locode DB skips points that do not have continents in presended geojson #3

Closed carpawell closed 2 years ago

carpawell commented 3 years ago

Problem

Presented geojson is a little bit rough: some pieces of land may not belong to any continent. It leads to skipping such places and not including them in our DB, e.g. there is no Stockholm in fixed after #2 DB.

Possible solutions:

  1. Do nothing. It is impossible to bootstrap nodes with some locodes then since IR does not know about them.
  2. Try our best: use airport position(s) of the current city(if it has such) and hope that is included in our geojson.
  3. Try our best: find out how to say which continent current County/SubLocation belongs to.
  4. Fill our DB with empty Continent field(or drop it at all).
  5. Make geojson more accurate(almost impossible).
  6. ...

I tried to find out if point derivation using the airport(one per city) helps much and got such results:

Total LOCODES: 112396
Does not have continents, but the airport(try one airport per city) does not have a continent too: 151
Neither has continents nor has airport: 3778
Has airports and it can be used as a location: 165
carpawell commented 3 years ago

Why Stockholm is so problematic in our case: image

alexvanin commented 3 years ago

Do nothing. Make it is possible to bootstrap nodes without continent.

carpawell commented 3 years ago

Suggest adding Unknown or Undefined Continent to our db in problem cases.

Should an IR skip such Continent SN attributes or it is OK to have an SN in the netmap with Continent:Unknown attribute?