search

nspcc-dev / neo-go

Go Node and SDK for the NEO blockchain
MIT License
118 stars 77 forks source link

inconsistent cli help information for db dump #3498

Open ixje opened 4 weeks ago

ixje commented 4 weeks ago

This is just a minor inconsistency in the help description

Current Behavior

./bin/neo-go db
NAME:
   neo-go db - database manipulations

USAGE:
   neo-go db command [command options] [arguments...]

COMMANDS:
   dump     dump blocks (starting with block #1) to the file

Note how for the dump command it states starting with block #1

Showing the help for the dump command states that start from defaults to 0 instead of 1

./bin/neo-go db dump -h
NAME:
   neo-go db dump - dump blocks (starting with block #1) to the file

USAGE:
   neo-go db dump -o file [-s start] [-c count] [--config-path path] [-p/-m/-t] [--config-file file]

OPTIONS:
   ...
   --start value, -s value  block number to start from (default: 0) (default: 0)

Expected Behavior

I believe these two should be the same, whichever is the right one.

Your Environment

AnnaShaleva commented 3 weeks ago

It starts from the genesis by default, thus, it's dump's usage should be adjusted.