search

nspcc-dev / neo-go

Go Node and SDK for the NEO blockchain
MIT License
122 stars 78 forks source link

smartcontrct: take care of manifest permission descriptor wildcardness #3544

Closed AnnaShaleva closed 1 month ago

AnnaShaleva commented 1 month ago

Starting from b10af1ed313283e081199a24cbda5ae5c99427b0 (*WildPermissionDescs).Add method's call is not enough to construct a proper restricted permission descriptor, because Wildcard field should be set properly at the same time. Ref. #3523.

There's nothing critical in the current implementation, but at the same time this PR allows to avoid possible future bug.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.05%. Comparing base (d8e3e57) to head (2c74305). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3544 +/- ## ========================================== - Coverage 86.08% 86.05% -0.04% ========================================== Files 330 330 Lines 38678 38680 +2 ========================================== - Hits 33297 33285 -12 - Misses 3840 3850 +10 - Partials 1541 1545 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

roman-khimov commented 1 month ago

Test?