search

nspcc-dev / neo-go

Go Node and SDK for the Neo blockchain
MIT License
123 stars 79 forks source link

cli: increase NeoFS pool deadlines for upload-bin command #3625

Closed AliceInHunterland closed 1 month ago

AliceInHunterland commented 1 month ago

Close #3620

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.27%. Comparing base (8e1fdd5) to head (41873e3). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3625 +/- ## ========================================== - Coverage 83.36% 83.27% -0.09% ========================================== Files 334 334 Lines 46440 46445 +5 ========================================== - Hits 38714 38678 -36 - Misses 6152 6193 +41 Partials 1574 1574 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AnnaShaleva commented 1 month ago

Have you tried to upload with the updated timeouts? Was uploading operation interrupted by timeout?

AliceInHunterland commented 1 month ago

Currently, the NeoFS mainnet is responding slowly or not responding at all. The pool is failing with timeouts. On the testnet, the default values have been sufficient and are still working fine. Even though testnet hardware is quite limited and should be much slower than the mainnet, it is hard to adjust the parameters accurately at this point. I tried changing both The Stream and Dual timeout settings. Only with larger values for both was the uploader able to upload a few batches, but it took a couple of hours, which is unacceptable. Now, the uploader can't even get a response from the search request. Our side is functioning as expected, but something has gone wrong on the NeoFS side.

AliceInHunterland commented 1 month ago

just in case -s 60s should be provided for increasing neo-go timeout too

./bin/neo-go util upload-bin --cid HmP48JvCcmiEbJemG7jFNEg2qkdCTx4thD3EwWUi288Q --wallet-config ./wallet-config.yml --block-attribute block --index-attribute index --rpc-endpoint https://rpc.t5.n3.nspcc.ru:20331 -fsr st1.storage.fs.neo.org:8080 -fsr st2.storage.fs.neo.org:8080 -fsr st3.storage.fs.neo.org:8080 -fsr st4.storage.fs.neo.org:8080 -s 60s

AnnaShaleva commented 1 month ago

for increasing neo-go timeout too

RPC client timeout doesn't affect ordinary RPC requests, AFAIK.

AnnaShaleva commented 1 month ago

RPC client timeout doesn't affect ordinary RPC requests, AFAIK.

My bad, of course it does, I just missed that line in code.