search

nspcc-dev / neo-go

Go Node and SDK for the Neo blockchain
MIT License
123 stars 79 forks source link

Uploader finds first full batch wrongly #3667

Closed AliceInHunterland closed 1 week ago

AliceInHunterland commented 2 weeks ago

The first block of the latest incomplete batch can't exceed the chain block height.

Current Behavior


  |   | 2024-11-11 07:08:35.735 | No new blocks to upload. Need to upload starting from 6670000, current height 6669795 |  
  |   | 2024-11-11 07:08:35.735 | First block of latest incomplete batch uploaded to NeoFS container: 6670000 |  
  |   | 2024-11-11 07:07:27.374 | Chain block height: 6669795

Expected Behavior

Vice versa.

Possible Solution

Check this case.

AnnaShaleva commented 2 weeks ago

can't exceed the chain block height.

Technically it can in case if uploader uses out-of-date RPC node. But in our case uploader always uses a single RPC node, hence we have a bug.