search

nspcc-dev / neofs-contract

NeoFS smart-contract
GNU General Public License v3.0
10 stars 17 forks source link

Squash Transfer and TransferX methods of balance contract #319

Closed AnnaShaleva closed 1 year ago

AnnaShaleva commented 1 year ago

After notary-disabled mode will be removed from the contracts (https://github.com/nspcc-dev/neofs-contract/issues/303) we can safely remove TransferX method moving its functionality to the Transfer method. The functionality itself differs from simple Transfer in two ways: 1) TansferX must be witnessed by alphabet multisig. 2) Transfer details must be provided (can be handled via transfer data parameter).

This allows us to simplify contract's interface a bit.

Ref. #304.

roman-khimov commented 1 year ago

But we need it to be NEP-17, aren't we?

AnnaShaleva commented 1 year ago

Yes, and I don't see the problem here. We'll keep single Transfer method with four parameters. Could you clarify the issue?

roman-khimov commented 1 year ago

I'll be incompatible with NEP-17, so any NEP-17 things we have (like transfer tracking) won't work for it.

AnnaShaleva commented 1 year ago

Oh, you're right, we can't do this.