nspcc-dev / neofs-contract

NeoFS smart-contract
GNU General Public License v3.0
10 stars 17 forks source link

nns: Confusing type system of the contract #335

Closed cthulhu-rider closed 9 months ago

cthulhu-rider commented 1 year ago

https://pkg.go.dev/github.com/nspcc-dev/neofs-contract@v0.17.0/nns

I'm slightly confused by the contract API. We deal with

If both of these elements are about the same entity, then I'd expect uniformity in method parameters.

I suppose this came from docs

the domain name itself is your NFT

Possible solution

Replace tokenID []byte with name string everywhere and don't forget about backwards.

roman-khimov commented 1 year ago

tokenID is used in NEP-11-compliant APIs, I guess, so it's a feature.

roman-khimov commented 9 months ago

Can't be done.