search

nspcc-dev / neofs-contract

NeoFS smart-contract
GNU General Public License v3.0
10 stars 17 forks source link

NNS update rebased #420

Closed roman-khimov closed 1 week ago

roman-khimov commented 3 months ago

It's a rebase of https://github.com/nspcc-dev/neofs-contract/pull/266 with some additions. It largely intersects with https://github.com/nspcc-dev/neofs-contract/pull/419, but has two additional ones. Not intended to be merged immediately.

roman-khimov commented 3 months ago

After #419 merge this completely substitutes #266 with the only two changes left.

carpawell commented 3 months ago

Rebase?

roman-khimov commented 3 months ago

Doesn't matter much at this stage.

carpawell commented 3 months ago

Is it post-release?

roman-khimov commented 3 months ago

That's why it's not a part of #419, see above.

carpawell commented 3 months ago

I see it is (was) based on #419 and has some additional changes but I do not see an explanation as to why not add it to the release. Dont mind though.

roman-khimov commented 3 months ago

Because of API changes, https://github.com/nspcc-dev/neofs-contract/pull/266#pullrequestreview-1638131153.

cthulhu-rider commented 3 months ago

as well as i'd like to ask in #266 - pls describe motivation in the commits. Now it looks like "lets change just like that", but the behavior of the contract changes. Mb @AnnaShaleva will remind us being an original author

roman-khimov commented 3 weeks ago

The main motivation here is https://github.com/nspcc-dev/neo-go/issues/2795. It's not related to #442/C#, btw, since C# interfaces for these methods are very much different. If we're to solve https://github.com/nspcc-dev/neo-go/issues/2795 this becomes irrelevant, I think.