search

nspcc-dev / neofs-dev-env

NeoFS local Development and Testing environment
https://fs.neo.org
GNU General Public License v3.0
9 stars 25 forks source link

services: Check for empty URL and path in Makefile targets #254

Closed vvarg229 closed 1 year ago

vvarg229 commented 1 year ago

This patch adds checks to ensure that the NEOFS_CLI_URL, NEOFS_CLI_PATH, NEOFS_ADM_URL, NEOFS_ADM_PATH, NEO_GO_URL, NEO_GO_PATH, S3_AUTHMATE_URL, and S3_GW_PATH variables are not empty before attempting to download or copy binaries using curl or cp.

Previously, if the variables were empty, the Makefile would produce the following error messages: curl: no URL specified! curl: try 'curl --help' or 'curl --manual' for more information tar: neofs-adm.tar.gz: Cannot open: No such file or directory tar: Error is not recoverable: exiting now rm: cannot remove 'neofs-adm.tar.gz': No such file or directory

These errors do not impact the 'make up' target and test environment setup, but they affect the 'prepare-test-env' target used for test automation and user convenience. The new checks eliminate these false error messages and improve overall user experience.

notimetoname commented 1 year ago

So neofs-dev-env is broken now because of missing that PR? Any progress on that? Im too unfamiliar with recent updates, could review it later.

vvarg229 commented 1 year ago

So neofs-dev-env is broken now because of missing that PR? Any progress on that? Im too unfamiliar with recent updates, could review it later.

No, it's just a small improvement that outputs messages in case of an error. It is useful for debugging

notimetoname commented 1 year ago

No, it's just a small improvement that outputs messages in case of an error.

@vvarg229 oh, i see. Just was scared of such logs locally but yes seems like it does not interrupt the normal flow. BTW are make[1]: Entering directory '/home/carpawell/NSPCC/git/neofs-dev-env' messages OK?

vvarg229 commented 1 year ago

No, it's just a small improvement that outputs messages in case of an error.

@vvarg229 oh, i see. Just was scared of such logs locally but yes seems like it does not interrupt the normal flow. BTW are make[1]: Entering directory '/home/carpawell/NSPCC/git/neofs-dev-env' messages OK?

Yes, messages like that are OK