search

nspcc-dev / neofs-dev-env

NeoFS local Development and Testing environment
https://fs.neo.org
GNU General Public License v3.0
9 stars 25 forks source link

*: Never restart any service #304

Closed carpawell closed 7 months ago

carpawell commented 10 months ago

If a user runs services in the devenv it is most likely that they want it to work and serve for some purposes trying their best. Unconditional restart is also smth that you usually can see on a real machines.

carpawell commented 10 months ago

If something fails

Then it should be zero exit code. If it exits with non-zero code, nothing changes with this PR.

not masking the behavior with restart (which if OK for production).

Do not see any differences. In both you should go with caution, you have logs, you have docker stats (uptime), healthchecks.

I do not insist, but on-failure is senseless to me (moreover, not every service has it).

roman-khimov commented 10 months ago

Maybe it should be "never" then?

carpawell commented 10 months ago

Maybe it should be "never" then?

That is better to me than on-failure (if every service has it). At least that means something.

carpawell commented 8 months ago

@roman-khimov, let's do something here. never and merge or just closing?

roman-khimov commented 8 months ago

I'd ask @cthulhu-rider first of all. IMO never is the best option, but I'm not using dev-env that often.

smallhive commented 8 months ago

I suffer from such restarts as well. After laptop restart dev-env in broken state and you have to drop and start again

carpawell commented 7 months ago

Changed to never, @all, make your choices.

carpawell commented 7 months ago

Well, not exactly that all...

roman-khimov commented 7 months ago

@nspcc-dev, @nspcc-dev/neofs-core, @nspcc-dev/neofs-services

cthulhu-rider commented 7 months ago

btw is never a correct setting? https://docs.docker.com/compose/compose-file/compose-file-v2/#restart

seems like it should be no which is default