search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
32 stars 38 forks source link

0.39.0 ir version metric dropped #2677

Closed 532910 closed 9 months ago

532910 commented 9 months ago 
% neofs-ir --version
NeoFS Inner Ring node
Version: 0.39.0 
GoVersion: go1.21.1
% curl -s localhost:9901 | grep '^neofs_ir_version'
%
% neofs-ir --version
NeoFS Inner Ring node
Version: v0.38.1 
GoVersion: go1.20.4
% curl -s localhost:9901 | grep '^neofs_ir_version'
neofs_ir_version{version="v0.38.1"} 1
carpawell commented 9 months ago

@532910, can you check that 9901 is the right port? Can not reproduce it.

532910 commented 9 months ago

yes, the port is correct, you can check it yourself on tenes1

roman-khimov commented 9 months ago

It's synchronizing the chain and IR is not yet really active. But yeah, it can be improved.

532910 commented 9 months ago

It's synchronizing the chain and IR is not yet really active. But yeah, it can be improved.

tenes6 and tenes7 has external cn and also doesn't provide this metric, so chain synchronizing is not related.

carpawell commented 9 months ago

@532910, is curl -s localhost:9901 healthy? Can you ensure that we dropped the metric, meaning all the metrics are available but no version found?

532910 commented 9 months ago

sure, you can check it yourself:

[sergio@tenes7:~]% neofs-ir --version
NeoFS Inner Ring node
Version: 0.39.0 
GoVersion: go1.21.1
[sergio@tenes7:~]% curl -s localhost:9901 | grep '^go_info'
go_info{version="go1.21.1"} 1
[sergio@tenes7:~]% curl -s localhost:9901 | grep '^neofs_ir_version'                                                      
zsh: done       curl -s localhost:9901 | 
zsh: exit 1     grep --color=always --initial-tab '^neofs_ir_version'
[sergio@tenes7:~]% s lsof -i -stcp:listen | grep neofs-ir           
neofs-ir  25188        neofs-ir    7u  IPv4 1762578      0t0  TCP localhost:9902 (LISTEN)
neofs-ir  25188        neofs-ir    8u  IPv4 1762582      0t0  TCP localhost:9901 (LISTEN)
[sergio@tenes7:~]% 
[sergio@tenes5:~]% neofs-ir --version
NeoFS Inner Ring node
Version: v0.38.1 
GoVersion: go1.20.4
[sergio@tenes5:~]% curl -s localhost:9901 | grep '^go_info'
go_info{version="go1.20.4"} 1
[sergio@tenes5:~]% curl -s localhost:9901 | grep '^neofs_ir_version'
neofs_ir_version{version="v0.38.1"} 1
[sergio@tenes5:~]% s lsof -i -stcp:listen | grep neofs-ir
neofs-ir    850        neofs-ir    8u  IPv4   15313      0t0  TCP tenes5.nspcc.ru:50333 (LISTEN)
neofs-ir    850        neofs-ir   13u  IPv4   15401      0t0  TCP tenes5.nspcc.ru:50332 (LISTEN)
neofs-ir    850        neofs-ir   14u  IPv4   15402      0t0  TCP tenes5.nspcc.ru:50331 (LISTEN)
neofs-ir    850        neofs-ir   26u  IPv4   15663      0t0  TCP localhost:9901 (LISTEN)
neofs-ir    850        neofs-ir   27u  IPv4   15667      0t0  TCP localhost:9902 (LISTEN)
neofs-ir    850        neofs-ir   29u  IPv4   15759      0t0  TCP localhost:8090 (LISTEN)
[sergio@tenes5:~]%
carpawell commented 9 months ago

Yeah, i see. Well, https://github.com/nspcc-dev/neofs-node/pull/2679 should really do the work. It has not been dropped, it is just added after the internal consensus is initiated, the error can't be caught cause there were no internal consensus runs (i did not check it in devenv too). Checked one more time in the AIO with internal consensus and the metrics are ok (not dropped, not overwritten and not any other scary things).