search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
32 stars 38 forks source link

node: Optimize verification of the request signatures #2684

Open cthulhu-rider opened 11 months ago

cthulhu-rider commented 11 months ago

Is your feature request related to a problem? Please describe.

NeoFS API server sometimes wastes large amounts of memory. For example, to verify request signatures, the server decodes messages into intermediate structures, encodes its parts (field-ordered Protocol Buffers V3), verifies signatures and request continues processing.

Describe the solution you'd like

do not perform extra decode-encode stages. To do this, we must arrange the fields in the message without an additional buffer, calculate the checksum and verify the signature. Nothing blocks us from this cuz Protobuf is pretty simple and gRPC lib provides a lot of utilities around it

Describe alternatives you've considered

leave as it is: simpler code but worse performance

cthulhu-rider commented 9 months ago

lets postpone this issue a bit, several more fundamental optimizations are coming with v0.40. It'd better to intro current optimization above those ones