Closed cthulhu-rider closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 22.03%. Comparing base (
14b650c
) to head (1ed7850
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
be removed
why be removed? just update a place to look at to be sure the tests are ok?
why be removed? just update a place to look at to be sure the tests are ok?
reader is guided how to make release, not how to plan it or check its readiness
Dont get you. That is a checklist that ensures everything is ok. What is the difference b/w go fmt
/go test
(that are ok and that should be kept according to you) and the integrational tests?
Running neofs-testcases is not trivial and time-consuming, so we should refer to it, but results are expected to be already available.
What is the difference b/w go fmt/go test (that are ok and that should be kept according to you) and the integrational tests?
1st are stylistic recommendations that can be instafixed in most cases (or postfixed in others), 2nd - about release planning. If release is ready-to-go, reader follows the guide that always finishes with the release done
1st are stylistic recommendations that can be instafixed in most cases
go test
/go mod tidy
too?
btw we also have https://github.com/nspcc-dev/neofs-node/blob/df2cc08a08191ce0f6ff84f36c393ed9b26f20da/docs/release-instruction.md?plain=1#L12: need to ref https://github.com/nspcc-dev/neofs-testcases or be removed since we have GH action with integration tests? @roman-khimov
i always skip this step