search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

Release guide fixes #2699

Closed cthulhu-rider closed 6 months ago

cthulhu-rider commented 8 months ago

btw we also have https://github.com/nspcc-dev/neofs-node/blob/df2cc08a08191ce0f6ff84f36c393ed9b26f20da/docs/release-instruction.md?plain=1#L12: need to ref https://github.com/nspcc-dev/neofs-testcases or be removed since we have GH action with integration tests? @roman-khimov

i always skip this step

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.03%. Comparing base (14b650c) to head (1ed7850).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2699 +/- ## ======================================= Coverage 22.03% 22.03% ======================================= Files 787 787 Lines 46763 46763 ======================================= + Hits 10304 10306 +2 + Misses 35576 35575 -1 + Partials 883 882 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carpawell commented 8 months ago

be removed

why be removed? just update a place to look at to be sure the tests are ok?

cthulhu-rider commented 8 months ago

why be removed? just update a place to look at to be sure the tests are ok?

reader is guided how to make release, not how to plan it or check its readiness

carpawell commented 8 months ago

Dont get you. That is a checklist that ensures everything is ok. What is the difference b/w go fmt/go test (that are ok and that should be kept according to you) and the integrational tests?

roman-khimov commented 8 months ago

Running neofs-testcases is not trivial and time-consuming, so we should refer to it, but results are expected to be already available.

cthulhu-rider commented 8 months ago

What is the difference b/w go fmt/go test (that are ok and that should be kept according to you) and the integrational tests?

1st are stylistic recommendations that can be instafixed in most cases (or postfixed in others), 2nd - about release planning. If release is ready-to-go, reader follows the guide that always finishes with the release done

carpawell commented 8 months ago

1st are stylistic recommendations that can be instafixed in most cases

go test/go mod tidy too?