nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

fix/Storage engine panics #2710

Closed carpawell closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 292 lines in your changes are missing coverage. Please review.

Comparison is base (d1309ab) 28.81% compared to head (d413612) 28.78%.

Files Patch % Lines
cmd/neofs-node/storage.go 0.00% 133 Missing :warning:
cmd/neofs-node/config.go 0.00% 90 Missing :warning:
cmd/neofs-node/container.go 0.00% 21 Missing :warning:
cmd/neofs-node/morph.go 0.00% 20 Missing :warning:
cmd/neofs-node/notificator.go 0.00% 7 Missing :warning:
cmd/neofs-node/object.go 0.00% 5 Missing :warning:
cmd/neofs-node/metrics.go 0.00% 3 Missing :warning:
cmd/neofs-node/pprof.go 0.00% 3 Missing :warning:
cmd/neofs-node/attributes.go 0.00% 2 Missing :warning:
cmd/neofs-node/control.go 0.00% 2 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2710 +/- ## ========================================== - Coverage 28.81% 28.78% -0.03% ========================================== Files 414 415 +1 Lines 32351 32371 +20 ========================================== - Hits 9321 9319 -2 - Misses 22196 22217 +21 - Partials 834 835 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carpawell commented 8 months ago

Local big suit run was ok (but I did some refactoring just right before the last push, as I love). Any big problems are not expected. Anyway, I will be able to fix them fast if the merge to the master fails.

carpawell commented 8 months ago

commend the refactor, but pls dont mess it with bugfix in the single commit next time

@cthulhu-rider, totally agree, but as I remember (I really tried it a few times), it just could not be fixed easily after the first two attempts without panicking somewhere else.