Closed carpawell closed 5 months ago
Well, I need Go 1.20 now. Otherwise, I am ready.
Not sure what is wrong with the tests: it creates REP 2 IN X CBF 1 SELECT 4 FROM * AS X
container PUTs a complex object and HEADs its parts with TTL 1 to every container node (2 of 4 answers correct, the other 2 say 404). Need to be investigated, not sure why all 4 nodes are expected to answer. Generally can be reviewed, draft status is caused by that strange test.
@roman-khimov affirmative
@carpawell wt readiness? PR is still draft
@carpawell wt readiness? PR is still draft
Basically can be reviewed since the push that allowed building. Some fixes are done (and will be done but are based on my work with int test cases) and after the review (when the base code is fixed), I would add some missing unit tests.
Codecov Report
Attention: Patch coverage is
14.28571%
with468 lines
in your changes are missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2716 +/- ## ========================================== - Coverage 22.04% 22.00% -0.04% ========================================== Files 787 789 +2 Lines 46738 47212 +474 ========================================== + Hits 10304 10390 +86 - Misses 35552 35930 +378 - Partials 882 892 +10 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.