search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

fix/Child objects ACL #2716

Closed carpawell closed 5 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 14.28571% with 468 lines in your changes are missing coverage. Please review.

Project coverage is 22.00%. Comparing base (9c6573c) to head (d309b9d).

Files Patch % Lines
pkg/services/object/util/chain.go 0.00% 97 Missing :warning:
pkg/services/object/split/verify.go 0.00% 86 Missing :warning:
pkg/services/object/get/assembly_v2.go 21.87% 75 Missing :warning:
cmd/neofs-node/object.go 0.00% 47 Missing :warning:
cmd/neofs-cli/modules/object/util.go 0.00% 42 Missing :warning:
pkg/services/object/delete/util.go 0.00% 26 Missing :warning:
cmd/neofs-cli/modules/storagegroup/put.go 0.00% 23 Missing :warning:
pkg/core/object/fmt.go 52.63% 17 Missing and 1 partial :warning:
pkg/local_object_storage/metabase/put.go 30.00% 8 Missing and 6 partials :warning:
pkg/services/object/acl/eacl/v2/headers.go 44.44% 7 Missing and 3 partials :warning:
... and 11 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2716 +/- ## ========================================== - Coverage 22.04% 22.00% -0.04% ========================================== Files 787 789 +2 Lines 46738 47212 +474 ========================================== + Hits 10304 10390 +86 - Misses 35552 35930 +378 - Partials 882 892 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carpawell commented 6 months ago

Well, I need Go 1.20 now. Otherwise, I am ready.

carpawell commented 6 months ago

Not sure what is wrong with the tests: it creates REP 2 IN X CBF 1 SELECT 4 FROM * AS X container PUTs a complex object and HEADs its parts with TTL 1 to every container node (2 of 4 answers correct, the other 2 say 404). Need to be investigated, not sure why all 4 nodes are expected to answer. Generally can be reviewed, draft status is caused by that strange test.

cthulhu-rider commented 6 months ago

@roman-khimov affirmative

@carpawell wt readiness? PR is still draft

carpawell commented 6 months ago

@carpawell wt readiness? PR is still draft

Basically can be reviewed since the push that allowed building. Some fixes are done (and will be done but are based on my work with int test cases) and after the review (when the base code is fixed), I would add some missing unit tests.