search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

ir: Do not create new notary requests for SN netmap entrances #2717

Closed carpawell closed 7 months ago

carpawell commented 7 months ago

See #2612, https://github.com/nspcc-dev/neofs-contract/pull/324. Refs #830.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (de84b12) 28.78% compared to head (511f7a2) 28.78%.

Files Patch % Lines
pkg/innerring/processors/netmap/process_peers.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2717 +/- ## ========================================== - Coverage 28.78% 28.78% -0.01% ========================================== Files 415 415 Lines 32388 32378 -10 ========================================== - Hits 9324 9319 -5 + Misses 22230 22224 -6 - Partials 834 835 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carpawell commented 7 months ago

Checked, works. Not sure if it closes https://github.com/nspcc-dev/neofs-node/issues/830. We definitely should do smth more, just look at these cute duplicated methods (not sure if there are any issue about it).