Closed carpawell closed 7 months ago
with these changes, broken sessions' verification by the IR wont be tested anymore since SNs wont bypass such sessions, right?
Seems so. But that is how the issues like "do not want to wait too long before IR reacts, pls, make it on the SN side" are fixed. Do not see any problems here.
IR tests are critical, so we must not lose them
Can be checked with neo-go
and notary requests anyway.
Attention: 10 lines
in your changes are missing coverage. Please review.
Comparison is base (
895559b
) 28.81% compared to head (53dc640
) 28.84%.:exclamation: Current head 53dc640 differs from pull request most recent head f8620ff. Consider uploading reports for the commit f8620ff to get more accurate results
Files | Patch % | Lines |
---|---|---|
pkg/services/container/morph/executor.go | 66.66% | 5 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can be checked with neo-go and notary requests anyway.
not everybody will be ready for this. I'd add a remark to Updating
section of the changelog
I'd add a remark to Updating section of the changelog
Not sure what an updater should see in this line. Not sure how @532910 will react. But I tried a little.
But I tried a little.
anything i can look at?
anything i can look at?
Oh, has not pushed, my bad.
If container session token is incorrect, there is no need in Alphabet's check, the error can be returned immediately to a client; otherwise he has to wait for the TX to persist infinitely with not feedback. Closes #2466.