search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

object: Purge notification functionality #2750

Closed cthulhu-rider closed 4 months ago

cthulhu-rider commented 4 months ago
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 28.92%. Comparing base (3b0bc18) to head (a08075d).

:exclamation: Current head a08075d differs from pull request most recent head 70a6c98. Consider uploading reports for the commit 70a6c98 to get more accurate results

Files Patch % Lines
cmd/neofs-node/object.go 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2750 +/- ## ========================================== + Coverage 28.86% 28.92% +0.06% ========================================== Files 415 414 -1 Lines 32485 32345 -140 ========================================== - Hits 9376 9356 -20 + Misses 22265 22145 -120 Partials 844 844 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cthulhu-rider commented 4 months ago

Can you, please, drop that functionality in the dev-env too?

https://github.com/nspcc-dev/neofs-dev-env/pull/305. If i forgot smth, pls report there

roman-khimov commented 4 months ago
  1. To me it's tied to meta handling. There will be notifications eventually, but more usable ones.
carpawell commented 4 months ago

https://github.com/nspcc-dev/neofs-dev-env/pull/305. If i forgot smth, pls report there

Oh, that is great, has not seen it yet.