nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

Upgrade minimum required Go version to `1.20` #2754

Closed cthulhu-rider closed 4 months ago

cthulhu-rider commented 4 months ago
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 21.89%. Comparing base (3b7d09b) to head (2ff412c).

Files Patch % Lines
cmd/neofs-adm/internal/modules/morph/container.go 0.00% 6 Missing :warning:
cmd/blobovnicza-to-peapod/blobovniczatree/put.go 0.00% 3 Missing :warning:
cmd/neofs-cli/internal/client/sdk.go 0.00% 2 Missing :warning:
pkg/local_object_storage/writecache/flush.go 0.00% 2 Missing :warning:
cmd/neofs-cli/internal/key/raw.go 66.66% 1 Missing :warning:
pkg/local_object_storage/engine/engine.go 50.00% 1 Missing :warning:
pkg/local_object_storage/metabase/control.go 0.00% 1 Missing :warning:
pkg/local_object_storage/metabase/shard_id.go 0.00% 1 Missing :warning:
pkg/local_object_storage/util/logicerr/error.go 66.66% 1 Missing :warning:
pkg/services/policer/check.go 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2754 +/- ## ========================================== - Coverage 28.65% 21.89% -6.76% ========================================== Files 427 787 +360 Lines 33109 46643 +13534 ========================================== + Hits 9486 10213 +727 - Misses 22771 35554 +12783 - Partials 852 876 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cthulhu-rider commented 4 months ago

pkg/util/salt.go can be improved

done

roman-khimov commented 4 months ago

Conflicts.

roman-khimov commented 4 months ago

Conflicts now.