nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

.git: update tests workflow to use new dev env #2765

Closed evgeniiz321 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.04%. Comparing base (2840694) to head (9a81700). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2765 +/- ## ======================================= Coverage 22.04% 22.04% ======================================= Files 787 787 Lines 46738 46738 ======================================= Hits 10302 10302 Misses 35553 35553 Partials 883 883 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evgeniiz321 commented 4 months ago

@roman-khimov

RuntimeError: Command: ./neofs-adm --config /tmp/tmp_filectguuaknnt.yml morph generate-storage-wallet --alphabet-wallets '/tmp/tmp_dirhmbpkwoook' --storage-wallet '/tmp/tmp_fileuafanshixc' --label 'sn3' --initial-gas 10
  Error:
  return code: 1
  output: Error: invalid GAS amount : invalid decimal format

It seems like a bug here - https://github.com/nspcc-dev/neofs-node/blob/master/cmd/neofs-adm/internal/modules/morph/generate.go#L159 I guess instead of refillGasAmountFlag, there should be storageGasCLIFlag

carpawell commented 4 months ago

@evgeniiz321, https://github.com/nspcc-dev/neofs-node/pull/2766 should help