search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

Drop any internal client wrappers #2769

Open carpawell opened 4 months ago

carpawell commented 4 months ago

Is your feature request related to a problem? Please describe.

We do not want to use our own clients. IMO it is a bad sign.

Describe the solution you'd like

Drop https://github.com/nspcc-dev/neofs-node/tree/2840694035a93925d415d454dbf1a6a28f74e83f/cmd/neofs-cli/internal/client, https://github.com/nspcc-dev/neofs-node/tree/2840694035a93925d415d454dbf1a6a28f74e83f/pkg/innerring/internal/client and any other ways to wrap our wrappers.

Describe alternatives you've considered

Keep it a mess.

Additional context

Not clear why it is useful, not clear what is solves. More code, more ways to make an error.

roman-khimov commented 4 months ago

IIRC CLI client wraps some command-specific contents internally (it's still a bad code). IR is a subject of #2410.