search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
32 stars 38 forks source link

metabase: Do not search for the link object in the regular objects bucket #2788

Closed carpawell closed 6 months ago

carpawell commented 6 months ago

Link objects are stored in a separate bucket for V2 split. If no link object is found, fallback to the previous behavior or try to find the last object. Also, do not try to unmarshal empty object payload, since it leads to hard-to-debug parsing errors in logs, while not having children objects at all is a correct case.

carpawell commented 6 months ago

TBH, has not tested all the cases since I've got some sort of a deadlock in the tests locally. Not sure what happened.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 22.02%. Comparing base (f4812fa) to head (4958f4d).

Files Patch % Lines
pkg/local_object_storage/metabase/get.go 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2788 +/- ## ======================================= Coverage 22.02% 22.02% ======================================= Files 789 789 Lines 47228 47232 +4 ======================================= + Hits 10401 10403 +2 - Misses 35934 35935 +1 - Partials 893 894 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.