search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

Do not ignore errors ever #2800

Open carpawell opened 3 months ago

carpawell commented 3 months ago

Expected Behavior

Never ignore errors in gonang.

Current Behavior

Code may ignore some errors (even if they are not expected at all, that is not good).

Possible Solution

Panic if an error is not expected at all.

Context

At least CLIs are affected: binding flags, getting flags, marking flags. Some other places may be affected too.

roman-khimov commented 3 months ago

Narrow down the scope, please. This is too broad.

carpawell commented 3 months ago

Narrow down the scope, please.

Finding all the places == 90% of solving the issue. We do ignore errors sometimes (Context has 3 examples with cobra lib errs ignorance). What exact do you mean?