nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

Run neofs-testcases for linux-arm64 #2824

Closed roman-khimov closed 1 month ago

roman-khimov commented 2 months ago

Is your feature request related to a problem? Please describe.

I'm always frustrated when I don't know if our node works for linux-arm64.

Describe the solution you'd like

Run testcases on linux-arm64 and see how it goes.

Additional context

This will allow us to have proper arm64 releases and cut down some infra costs (arm64 machines are cheaper). This will also allow to have Docker images that work for ARM-based Macs.

roman-khimov commented 2 months ago

It may require macos-14 runner and darwin-arm64 in fact, but this combination fits the purpose as well.

evgeniiz321 commented 2 months ago

@roman-khimov here is the PR with a try - https://github.com/nspcc-dev/neofs-node/pull/2825 2 problems there:

  1. Current binaries (neo-go/neofs-s3-gw/neofs-rest-gw) from releases are not suitable to run on macos runners, even though some binaries are marked/named as darwin/arm64, all of them fail with the invalid CPU type or something similar. To make it work I had to build everything manually inside the workflow.
  2. Allure reports publishing to neofs is not supported for arm64. There are problems both in our action and in simple-elf/allure-report-action@v1.6 that we use inside to generate reports, it only supports linux runners.
roman-khimov commented 2 months ago
  1. linux-arm64 images should work for MacOS as well. @mike-petrov, you're using them, right?
  2. Our action depends on neofs-cli, so in absence of linux-arm64 binary it's hard for it to work. But allure-report-action dependency is more worrisome.

At the same time, can you build everything locally and run testcases on Mac? What's the status for them in this case? If they're confirmed to be OK we can at least start enabling appropriate builds which will solve a part of the problem.

mike-petrov commented 2 months ago

I don't know which image I'm using, but everything works

roman-khimov commented 1 month ago

Fixed in #2835, please be more careful with "fixes/closes".