search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
31 stars 38 forks source link

pkg/morph/container: Do not create client with notary status #2830

Closed carpawell closed 2 months ago

carpawell commented 2 months ago

Provide notary signature status with explicit parameter. Some calls are always expected to be Alphabet signed (at least for the current contracts), make it explicit for a code reader, that is more error proof. This commit also fixes container size estimations writing: they were tried to be notary signed, but the Alphabet does not handle such requests. This is also the reason why this kinda refactor does not touch other contracts; general client improvements can be done with another PR.

roman-khimov commented 2 months ago

You only change container defaults though, so likely these are fine.

carpawell commented 2 months ago

I fear it can break things.

You only change container defaults though, so likely these are fine.

Yes, StaticClient now has an additional flag but only container client uses it, so I do not expect anything breaking here. The commit has some words about why it is not a global client refactor, that is just a fix.

roman-khimov commented 2 months ago

Yup, convincing.