search

nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
32 stars 38 forks source link

Make RPC client try more #2996

Closed roman-khimov closed 2 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 278 lines in your changes missing coverage. Please review.

Project coverage is 22.91%. Comparing base (838126c) to head (5ec3d5a). Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
pkg/morph/client/client.go 0.00% 81 Missing :warning:
pkg/morph/client/constructor.go 0.00% 60 Missing :warning:
pkg/morph/client/connection.go 0.00% 40 Missing :warning:
pkg/morph/client/notary.go 0.00% 34 Missing :warning:
pkg/morph/client/notifications.go 0.00% 34 Missing :warning:
pkg/morph/client/multi.go 0.00% 20 Missing :warning:
pkg/morph/client/nns.go 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2996 +/- ## ========================================== + Coverage 22.88% 22.91% +0.03% ========================================== Files 785 786 +1 Lines 58806 58709 -97 ========================================== - Hits 13457 13454 -3 + Misses 44469 44374 -95 - Partials 880 881 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

roman-khimov commented 2 weeks ago

The other change here is that the client will fail requests easily instead of blocking when it's disconnected. It's harder to predict the effect, but it seems to be more fair (associated requests will fail quickly instead of waiting for unknown time).