nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
32 stars 38 forks source link

metabase: drop almost all of Prm/Res structures #3001

Closed roman-khimov closed 2 weeks ago

roman-khimov commented 2 weeks ago

They:

Test wrappers in the same package perfectly suggest what everyone wanted to have in the first place. So this patch is a pure refactoring and doesn't change any behavior, but it drops almost all structures. "Almost" because there are cases where we pass a number of things (mostly as a result) and having some enclosing structure makes some sense there.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 63.19018% with 60 lines in your changes missing coverage. Please review.

Project coverage is 23.05%. Comparing base (2e583e5) to head (782005b). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-lens/internal/storage/sanity.go 0.00% 13 Missing :warning:
cmd/neofs-lens/internal/meta/list-graveyard.go 0.00% 10 Missing :warning:
pkg/local_object_storage/metabase/movable.go 53.33% 7 Missing :warning:
cmd/neofs-lens/internal/meta/get.go 0.00% 4 Missing :warning:
cmd/neofs-lens/internal/meta/list-garbage.go 0.00% 4 Missing :warning:
pkg/local_object_storage/metabase/status.go 0.00% 3 Missing :warning:
pkg/local_object_storage/metabase/storage_id.go 80.00% 3 Missing :warning:
pkg/local_object_storage/shard/list.go 40.00% 3 Missing :warning:
cmd/neofs-lens/internal/meta/list.go 0.00% 2 Missing :warning:
pkg/local_object_storage/metabase/put.go 71.42% 2 Missing :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3001 +/- ## ========================================== - Coverage 23.15% 23.05% -0.11% ========================================== Files 789 789 Lines 58815 58669 -146 ========================================== - Hits 13619 13526 -93 + Misses 44312 44262 -50 + Partials 884 881 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.