codecov[bot]
commented
2 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 23.07%. Comparing base (
eccab58) to head (d5de082). Report is 8 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #3003 +/- ## ======================================= Coverage 23.07% 23.07% ======================================= Files 789 789 Lines 58687 58686 -1 ======================================= Hits 13542 13542 + Misses 44263 44262 -1 Partials 882 882 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
internalErr has some buffer to accept multiple errors, but it only processes one of them, so if we have some cascading failures with multiple components reporting an error some of them will end up panicking because of closed channed. It's not very critical since the node is to die anyway, but it's nothing good either.
This particular case shouldn't really happen after #2996, but leaving this channel open is better than panic in case some other events lead to multiple sends to it.