nspcc-dev / neofs-node

NeoFS is a decentralized distributed object storage integrated with the Neo blockchain
https://fs.neo.org
GNU General Public License v3.0
32 stars 38 forks source link

ir/node: disable log sampling #3011

Closed roman-khimov closed 1 week ago

roman-khimov commented 1 week ago

The default Zap config is:

Sampling is enabled at 100:100 by default, meaning that after the first 100 log entries with the same level and message in the same second, it will log every 100th entry with the same level and message in the same second. You may disable this behavior by setting Sampling to nil.

It leads to message loss too easily and we care a lot about each and every object. Notice that it was disabled in NeoGo as well in a52e016c22de2269fcc7362f33317cebfa7e8e4c (https://github.com/nspcc-dev/neo-go/pull/598).

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 22.99%. Comparing base (007e992) to head (0ffbfc1). Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-ir/main.go 0.00% 1 Missing :warning:
cmd/neofs-node/config.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3011 +/- ## ========================================== - Coverage 23.06% 22.99% -0.07% ========================================== Files 790 790 Lines 58709 58502 -207 ========================================== - Hits 13542 13454 -88 + Misses 44285 44169 -116 + Partials 882 879 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.