codecov[bot]
commented
1 week ago Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
Project coverage is 22.83%. Comparing base (
b7714ae) to head (08aefce). Report is 8 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/services/object/acl/acl.go | 0.00% | 13 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #3015 +/- ## ========================================== - Coverage 22.84% 22.83% -0.01% ========================================== Files 790 790 Lines 58344 58347 +3 ========================================== - Hits 13328 13325 -3 - Misses 44136 44141 +5 - Partials 880 881 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
EACL can not have any rules for system role since 0.38.0 (ab909a371b069c9fcc728f617b1e29aeaf135ab2), so performing these checks is not very helpful. Of course one can still ban the node by key, but that would make a lot of regular operations fail and broken container is not very helpful.
This fixes #2972 as much as possible (containers can be cached for a longer period of time).