Closed smallhive closed 5 months ago
Attention: Patch coverage is 1.91388%
with 615 lines
in your changes are missing coverage. Please review.
Project coverage is 26.92%. Comparing base (
aadef93
) to head (127dd3e
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rebased
main commit with reslicing removal contains only issue ref which is good for GH but not enough for git history overall. Lets write some text about motivation and used approach
What happens if we're to reupload a part?
Everything will be broken. We collect full object hash moving from part to part. If you re-upload any part in the middle, we will have to re-read all parts after it, recalculate hashes, and re-upload parts
Everything will be broken. We collect full object hash moving from part to part. If you re-upload any part in the middle, we will have to re-read all parts after it, recalculate hashes, and re-upload parts
Cool. We need to do this. And that's where per-part IDs can become handy because
Part numbers can be any number from 1 to 10,000, inclusive. A part number uniquely identifies a part and also defines its position within the object being created. If you upload a new part using the same part number that was used with a previous part, the previously uploaded part is overwritten.
And btw,
Each part must be at least 5 MB in size, except the last part.
Everything will be broken. We collect full object hash moving from part to part. If you re-upload any part in the middle, we will have to re-read all parts after it, recalculate hashes, and re-upload parts
Cool. We need to do this. And that's where per-part IDs can become handy because
Part numbers can be any number from 1 to 10,000, inclusive. A part number uniquely identifies a part and also defines its position within the object being created. If you upload a new part using the same part number that was used with a previous part, the previously uploaded part is overwritten.
And btw,
Each part must be at least 5 MB in size, except the last part.
Added logic for re-upload parts
Closes #843