search

nspcc-dev / neofs-sdk-go

Go implementation of NeoFS SDK
Apache License 2.0
5 stars 14 forks source link

Upgrade to go 119 #522

Closed smallhive closed 11 months ago

smallhive commented 11 months ago

Close #492

carpawell commented 11 months ago

Can you, please, do the same as we did in the node repo? Is allows us to be sure this PR broke nothing in the other places.

carpawell commented 11 months ago

Also, the first two commits are the same for me. But up to you.

smallhive commented 11 months ago

Can you, please, do the same as we did in the node repo? Is allows us to be sure this PR broke nothing in the other places.

Works perfectly https://github.com/nspcc-dev/neofs-sdk-go/actions/runs/6269928793/job/17027095101?pr=522 :sweat_smile:

Do we suppress these errors? Fixing them may significantly affect the SDK API

roman-khimov commented 11 months ago

As for deprecation warnings, you can suppress them if there are no better ways (although it's somewhat strange to have something deprecated and not have a replacement).

smallhive commented 11 months ago

As for deprecation warnings, you can suppress them if there are no better ways (although it's somewhat strange to have something deprecated and not have a replacement).

Yes, maybe we should pay more attention to #25.

But what about:

panic? Changing the function API to return an error may significantly influence some code.

roman-khimov commented 11 months ago

With the current API you can return nil.

smallhive commented 11 months ago

Updated

carpawell commented 11 months ago

although it's somewhat strange to have something deprecated and not have a replacement

That is because of https://github.com/nspcc-dev/neofs-api/pull/205. No need to store SG's expiration as a payload's part if it is always an object that has its own expiration. So maybe deprecate SDK's getters too? Or even remove them. @smallhive, @roman-khimov, @cthulhu-rider