search

nspcc-dev / neofs-sdk-go

Go implementation of NeoFS SDK
Apache License 2.0
5 stars 14 forks source link

Increase test coverage of `accounting` and improve some test packages #590

Closed cthulhu-rider closed 2 weeks ago

carpawell commented 3 weeks ago

@cthulhu-rider, linter died. What about tests btw?

cthulhu-rider commented 3 weeks ago

@cthulhu-rider, linter died. What about tests btw?

fixed linter, AIO tests fail for some reason unrelated to the changes. I'll take a closer look, maybe create a separate issue

carpawell commented 2 weeks ago

AIO tests fail for some reason unrelated to the changes. I'll take a closer look, maybe create a separate issue

@cthulhu-rider, yes, have not found issues about it and do not know when they appeared first (to me this PR is the first one), so lets create an issue (if cannot be fixed fast) or fix it here (if possible).

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 73.01587% with 34 lines in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (11ca22b) to head (b069242). Report is 5 commits behind head on master.

Files Patch % Lines
user/test/id.go 75.00% 9 Missing and 1 partial :warning:
eacl/test/generate.go 0.00% 5 Missing :warning:
object/id/test/generate.go 86.20% 2 Missing and 2 partials :warning:
bearer/test/generate.go 0.00% 3 Missing :warning:
crypto/test/tests.go 85.71% 2 Missing and 1 partial :warning:
reputation/test/generate.go 0.00% 3 Missing :warning:
container/id/test/id.go 87.50% 1 Missing and 1 partial :warning:
container/test/generate.go 0.00% 2 Missing :warning:
object/test/generate.go 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #590 +/- ## ========================================== + Coverage 68.18% 68.78% +0.60% ========================================== Files 122 120 -2 Lines 10035 10043 +8 ========================================== + Hits 6842 6908 +66 + Misses 2814 2759 -55 + Partials 379 376 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cthulhu-rider commented 2 weeks ago

AIO tests fail for some reason unrelated to the changes. I'll take a closer look, maybe create a separate issue

@cthulhu-rider, yes, have not found issues about it and do not know when they appeared first (to me this PR is the first one), so lets create an issue (if cannot be fixed fast) or fix it here (if possible).

added fix commit