search

nspcc-dev / neofs-sdk-go

Go implementation of NeoFS SDK
Apache License 2.0
5 stars 14 forks source link

Account based eacl targets #592

Open smallhive opened 2 weeks ago

smallhive commented 2 weeks ago

Refs https://github.com/nspcc-dev/neofs-api/issues/278

cthulhu-rider commented 2 weeks ago

Why not API repo changes first?

there will be one comment in docs, no binary protocol changes. But we wanna review the concept in practice. In total, yes, we'll have to merge this and API simultaneously @smallhive

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.65%. Comparing base (3a0ae98) to head (8b59b64). Report is 19 commits behind head on master.

Files Patch % Lines
eacl/target.go 68.00% 4 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #592 +/- ## ========================================== + Coverage 53.61% 53.65% +0.04% ========================================== Files 164 164 Lines 19068 19104 +36 ========================================== + Hits 10223 10251 +28 - Misses 8436 8440 +4 - Partials 409 413 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smallhive commented 2 days ago

Updated to user.ID account meaning with 25 byte length