search

nspcc-dev / s3-tests

Compatibility tests for S3 clones
MIT License
3 stars 3 forks source link

Fix test_continuationtoken_empty #1

Closed masterSplinter01 closed 3 years ago

masterSplinter01 commented 3 years ago

Now this test processes an error in a response.

realloc commented 3 years ago

I suggest moving the fixed on to our own suite

alexvanin commented 3 years ago

I suggest moving the fixed on to our own suite

But this PR is already a request to merge the fix to master branch of our fork.

I think @realloc meant not to change existing test_bucket_listv2_continuationtoken_empty test, but to create one more test_bucket_listv2_continuationtoken_empty_fixed (choose better naming) test with fixed behavior.

This branch, however, can be used for upstream PR. But first let's run compatibility tests against AWS: https://github.com/nspcc-dev/neofs-s3-gw/issues/183. It will help to prove that our PR is valid.

KirillovDenis commented 3 years ago

We also can add some attribute (like this one @attr('fixed_to_neofs_s3_gate')) to be able to run such tests separately.

masterSplinter01 commented 3 years ago

Will add docs to confluence how to run tests with our attribute (fixed_to_neofs_s3_gw looks good enough for name of our suite?) after approve/merge.