search

nspcc-dev / s3-tests

Compatibility tests for S3 clones
MIT License
3 stars 3 forks source link

Upgrade cors tests #4

Closed masterSplinter01 closed 2 years ago

masterSplinter01 commented 2 years ago

Signed-off-by: Angira Kekteeva kira@nspcc.ru

masterSplinter01 commented 2 years ago

Issues with CORS tests:

Fixed s3tests_boto3.functional.test_s3_neofs.test_cors_origin_response_with_credentials fails with AWS because in case when in CORSConfiguration AllowedOrigin = '' AWS responds to requests with credentials with header access-control-allow-origin = '' that is not correct via docs:

Note: When responding to a credentialed requests request, the server must specify an origin in the value of the Access-Control-Allow-Origin header, instead of specifying the "*" wildcard.
KirillovDenis commented 2 years ago

The following tests fail on AWS S3:

Should we ensure that new tests pass on AWS?

masterSplinter01 commented 2 years ago

Why s3tests_boto3.functional.test_s3_neofs.test_cors_origin_response_with_credentials fails is explained in the comment above.

It's strange that test s3tests_boto3.functional.test_s3_neofs.test_cors_origin_response failed, because I restarted the tests and got the results (the same as earlier): 

s3tests_boto3.functional.test_s3_neofs.test_set_cors ... ok
s3tests_boto3.functional.test_s3_neofs.test_cors_origin_response ... ok
s3tests_boto3.functional.test_s3_neofs.test_cors_origin_response_with_credentials ... FAIL
s3tests_boto3.functional.test_s3_neofs.test_cors_origin_wildcard ... ok

Could you please retry the test test_cors_origin_response and attach logs from results?

KirillovDenis commented 2 years ago

AWS responds to requests with credentials with header access-control-allow-methods='*'

Do you mean access-control-allow-origin?

masterSplinter01 commented 2 years ago

Typo, yep, I mean access-control-allow-origin. Edited the comment.

KirillovDenis commented 2 years ago

Well... Currently the test pass. Some time ago I couldn't connect to AWS at all (perhaps it was related).