nspec / NSpec

A battle hardened testing framework for C# that's heavily inspired by Mocha and RSpec.
http://nspec.org/
MIT License
260 stars 57 forks source link

Rename XUnitFormatter to JUnitFormatter #179

Open BennieCopeland opened 7 years ago

BennieCopeland commented 7 years ago

So, apparently there is the xUnit format which is VERY similar to the JUnit format. Then there is the XUnit format used by the XUnit project with its own format. Guess which one works in TFS.

GiuseppePiscopo commented 7 years ago

Hi there,

could you please clarify a little more? I'm not getting it, my bad, as I don't use XUnit formatting a lot. To which format are you referring to when you say the xUnit format similar to...?

BennieCopeland commented 7 years ago

So I just learned this while trying to get my tests into TFS. There is xUnit which is a collective name for test frameworks patterned after Smalltalk's SUnit. The xUnit test result format came about from JUnit, and other xUnit style tests frameworks copied it.

Then there is XUnit.Net, which is another xUnit style test framework, but they have their own incompatible format. The TFS build step for importing a test results xml file supports JUnit, NUnit, VSTest, and XUnit (XUnit.Net). With this formatter named with XUnit, there was some confusion on my part on why TFS was failing to import my test results. Once I switched TFS to JUnit, it imported them fine.

GiuseppePiscopo commented 7 years ago

Oh, ok, now I see it. So our current XUnitFormatter is producing output compatible with the general xUnit framework, which in TFS is dubbed as JUnit.

Then TFS calls XUnit the format specific to xUnit.net, and this confuses things when selecting import format.

If this is the case, I'd say that we should put a note on this when we add docs on formatters. /cc @amirrajan

amirrajan commented 7 years ago

Or just create a new class called XUnitFormatterForTFS that just inherits? (With docs)

BennieCopeland commented 7 years ago

Started working on an XUnit.net formatter a few days ago. I'll continue when I get out of the hospital.

Sent from my iPhone

On Apr 1, 2017, at 17:24, Amir Rajan notifications@github.com wrote:

Or just create a new class called XUnitFormatterForTFS that just inherits? (With docs)

― You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.