search

nspec / NSpec

A battle hardened testing framework for C# that's heavily inspired by Mocha and RSpec.
http://nspec.org/
MIT License
260 stars 57 forks source link

XUnitFormatter fixes for issues #176, #177 and #178 #181

Closed BennieCopeland closed 7 years ago

BennieCopeland commented 7 years ago

I haven't been able to build it or test because I'm already on VS2017. I don't want to go upgrading your projects. I did however make a copy of XUnitFormatter in my unit test project and it worked with the changes.

BrainCrumbz commented 7 years ago

Thanks for this PR, will have a look at it. Yes, this is still VS2015-, project.json-based and it will probably stay like that for now (integrating with VS2017, of course, is another thing).

Side note, just in case: you can have on the same machine both VS2015 and 2017 (of course), and you can have preview2 .NET Core tooling together with RTM 1.0 .NET Core tooling, so that you can work on the same machine with project.json based solutions, as well as .NET Core csproj solutions.

BrainCrumbz commented 7 years ago

Heads up: putting together a couple of tests for issues you found, to also confirm fixes.

BrainCrumbz commented 7 years ago

Collectively, this PR should fix issues #176, #177 and #178