search

nspec / NSpec

A battle hardened testing framework for C# that's heavily inspired by Mocha and RSpec.
http://nspec.org/
MIT License
260 stars 57 forks source link

Walk through on VS2017 integrations #199

Open warwickfoster opened 7 years ago

warwickfoster commented 7 years ago

downloaded the Git repo and compiled in VS2017. Had the test adapter installed. Nothing appears in the test explorer. Do not have resharper installed. Did not want to try on CLI as I am looking for UI integration, Really like nspec and want to use it. Could someone download VS2017 enterprise and have a look at the integration for me and let me know what to do to get it in the interface.

Thank you. Really like nspec

BrainCrumbz commented 7 years ago

Hi there in our team we like nspec too, as much as to become contributors!

Thanks for taking the time to try to make it work. We have not been investing huge amounts of time lately, and state-of-the-art with VS2017 is a little bit foggy. Let's try to recap:

Our understanding is that in order to have a VS2017 adapter, one should somehow leave the dotnet-test type of runner and "go back" to the VS adapter type. Now, here's the crux:

Our current NSpec.VsAdapter is itself an old style-csproj project in .NET Framework. It has not been ported yet to .NET Core, nor to VS2017 csproj type of project. Also, it is built against a specific version of NSpec (non-.NET Core yet), and this is bad in general: it should instead dynamically reference the NSpec.dll coming with the test project it's running.

Some time ago we tried porting NSpec.VsAdapter initially just to .NET Core in a project.json/xproj project, and at the same time we tried making it dynamically reference NSpec.dll. There we hit the infamous Assembly.Load problems. We thought those had gone away for good, when we previously coded the same thing in dotnet-test runner (that one also loads NSpec dynamically from test project). After trying to solve those problems for some time, we did not have further chances to work at it again.

So, as you can guess, there's some (debug+dev) work to do in order to make VS adapter work in VS2017.

amirrajan commented 7 years ago

@warwickfoster looking forward to your VS2017 Enterprise test runner contributions.

warwickfoster commented 7 years ago

Yeah thinking about it. Got a couple of Monkeys on my back but keep needling me and ill give it a shot.

From: Amir Rajan [mailto:notifications@github.com] Sent: Saturday, 5 August 2017 1:04 PM To: nspec/NSpec NSpec@noreply.github.com Cc: warwickfoster warwick@foster.net; Mention mention@noreply.github.com Subject: Re: [nspec/NSpec] Walk through on VS2017 integrations (#199)

@warwickfoster https://github.com/warwickfoster looking forward to your VS2017 Enterprise test runner contributions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nspec/NSpec/issues/199#issuecomment-320391032 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEj15hpP7qwRQaCgeXuqzQAxr6n1yYWhks5sU9uigaJpZM4OqrQS . https://github.com/notifications/beacon/AEj15i9yG1cTa8YFBpDHaNcX8oQj-P3jks5sU9uigaJpZM4OqrQS.gif

ivan-prodanov commented 6 years ago

It's very unfortunate that I couldn't get this to work through the VS 2017 adapter for .NET Core 2 project (new .csproj format).

BrainCrumbz commented 6 years ago

We're not yet actively working on VS2017 / .NET Core 2 projects, also given the relative "instability" on the tooling side, that's the main reason. Please feel free to ask for info if you want to give a stab at that.

amirrajan commented 6 years ago

@ivan-prodanov dig in and figure it out :-)