nspire-emus / firebird

Multi-platform emulator of TI Nspire calculators
GNU General Public License v3.0
704 stars 69 forks source link

I'm Impressed, though not perfect. #232

Open gastondefer opened 3 years ago

gastondefer commented 3 years ago

Eventhough I'm not a programmer, I can sure appreciate the hard work that went toward this app over the years. I love this app, and I wanna make that clear! I'd gladly pay for this app if it was on the PlayStore, and NOT complain about all the minor bugs it'd have. It works fine in my opinion. In this post I'm just gonna be talking about my experience with the app.

I have 5 android phones at the moment and they are all recent phones, with the exception of a Galaxy S7 edge. So if you need some stuff tested on different phones, know that you have all my phones at your disposal.

I personally found the previous versions 1.4 to be more stable on all my phones. With version 1.5 the app immediately craches everytime when trying to load a file, the keyboard won't show in portrait mode when phone rotates to landscape mode, until you close the app and reopen it, portrait mode won't work.

The configuration menu looks really clean, but the options are very small and it was impossible for me to go to file transfer on my lg g8 due that option, alongside the others (emulation, debugging), being too close to the status bar ( I don't have big fingers by the way). Tough the new file manager is great, finding the required files to boot is very easy. I'm still testing the app however.

P.S. Sorry for making this such a long post, but I wanted you to know how much I appreciate your app, and I'm sure the same can be said for lots of people.

Vogtinator commented 3 years ago

With version 1.5 the app immediately craches everytime when trying to load a file,

When starting the emulation or on Select file?

the keyboard won't show in portrait mode when phone rotates to landscape mode, until you close the app and reopen it, portrait mode won't work.

Already fixed: #199

The configuration menu looks really clean, but the options are very small and it was impossible for me to go to file transfer on my lg g8 due that option, alongside the others (emulation, debugging), being too close to the status bar ( I don't have big fingers by the way). Tough the new file manager is great, finding the required files to boot is very easy. I'm still testing the app however.

Can you make a screenshot? I guess Qt's DPI detection doesn't work.

P.S. Sorry for making this such a long post, but I wanted you to know how much I appreciate your app, and I'm sure the same can be said for lots of people.

Thanks! Feedback especially for the mobile version is appreciated, because it's not the main version regularly used by devs and mobile platforms are very diverse...

gastondefer commented 3 years ago

1- Only on select file, when selecting the "flash file" only. The only way I was able to get 1.5 to work was to first install 1.4, load all the files (boot, flash, snapchat), then upgrade to 1.5.

2- Thanks for the #199 link, as it did fixed the keypad problem. I also took the liberty to test the 1.5dev.apk you had overthere, and it's the same as 1.5 a part from the keypad. Thought you'd like to know.

3- As for the configuration menu options looking small, I made a little unlisted youtube video: https://youtu.be/N70rpa6QhgE

It first shows a Galaxy S10e crashes and then LG G7. 50 secs mark is where I struggle selecting an option on LG G7. Sorry for the glare in the video

I also added an image of what the app looks like on a Galaxy S20 Ultra.

P.S. If you ever need me to test anything on the mobile version, please do not hesitate to ask. I don't mind making unlisted videos if that helps the project. It's the absolute least I can do. Anybody that uses this app owes you guys one; at least that's how I see it.

20210412_224535

Vogtinator commented 3 years ago

1- Only on select file, when selecting the "flash file" only. The only way I was able to get 1.5 to work was to first install 1.4, load all the files (boot, flash, snapchat), then upgrade to 1.5.

What't the version of Android? On recent versions (8+?) it doesn't allow immediate native file system access anymore, so we had to switch to a different method for file selection and access. Do you have the adb log for the crash?

2- Thanks for the #199 link, as it did fixed the keypad problem. I also took the liberty to test the 1.5dev.apk you had overthere, and it's the same as 1.5 a part from the keypad. Thought you'd like to know.

3- As for the configuration menu options looking small, I made a little unlisted youtube video: https://youtu.be/N70rpa6QhgE

It first shows a Galaxy S10e crashes and then LG G7. 50 secs mark is where I struggle selecting an option on LG G7. Sorry for the glare in the video

I also added an image of what the app looks like on a Galaxy S20 Ultra.

P.S. If you ever need me to test anything on the mobile version, please do not hesitate to ask. I don't mind making unlisted videos if that helps the project. It's the absolute least I can do. Anybody that uses this app owes you guys one; at least that's how I see it.

It's hard to tell whether that's because of scaling or the android style couldn't be loaded. Do the button look like proper buttons which are just too small? If so, then simply enabling Qt's auto scaling (Qt::AA_EnableHighDpiScaling) might help. Here's a test build: https://owncloud.ritter-vogt.de/index.php/s/OKKWpeo1Qwv1Ji8

If they don't look like buttons at all, here's a test build from the (WIP) port to Qt Quick Controls 2 on the qt6 branch (still using Qt 5.14 though), which basically uses a complete different implementation of the UI elements: https://owncloud.ritter-vogt.de/index.php/s/aNhoavXBzaupjMt

gastondefer commented 3 years ago

1- Only on select file, when selecting the "flash file" only. The only way I was able to get 1.5 to work was to first install 1.4, load all the files (boot, flash, snapchat), then upgrade to 1.5.

What't the version of Android? On recent versions (8+?) it doesn't allow immediate native file system access anymore, so we had to switch to a different method for file selection and access. Do you have the adb log for the crash?

2- Thanks for the #199 link, as it did fixed the keypad problem. I also took the liberty to test the 1.5dev.apk you had overthere, and it's the same as 1.5 a part from the keypad. Thought you'd like to know. 3- As for the configuration menu options looking small, I made a little unlisted youtube video: https://youtu.be/N70rpa6QhgE It first shows a Galaxy S10e crashes and then LG G7. 50 secs mark is where I struggle selecting an option on LG G7. Sorry for the glare in the video I also added an image of what the app looks like on a Galaxy S20 Ultra. P.S. If you ever need me to test anything on the mobile version, please do not hesitate to ask. I don't mind making unlisted videos if that helps the project. It's the absolute least I can do. Anybody that uses this app owes you guys one; at least that's how I see it.

It's hard to tell whether that's because of scaling or the android style couldn't be loaded. Do the button look like proper buttons which are just too small? If so, then simply enabling Qt's auto scaling (Qt::AA_EnableHighDpiScaling) might help. Here's a test build: https://owncloud.ritter-vogt.de/index.php/s/OKKWpeo1Qwv1Ji8

If they don't look like buttons at all, here's a test build from the (WIP) port to Qt Quick Controls 2 on the qt6 branch (still using Qt 5.14 though), which basically uses a complete different implementation of the UI elements: https://owncloud.ritter-vogt.de/index.php/s/aNhoavXBzaupjMt

Yes, all are above android 8. I don't know how to get the adb log; though if you guided on how to get that log, I'll definitely give it a shot.

- With version 1.5, the buttons don't really feel very much like actual buttons, as you don't sense or feel any kind of visual feedback WHILE touching them, if that makes sense.

- Ok, the first test build gave me some very interesting results. When I did a clean install, it didn't crash, and I was able to load all the files to start the emulation. However, during and upon its completion, everything on its screen was too large, making it unsuable (both portrait and landscape). I've done the test on android 10 and 11 (4 phones in total). 20210418_015411

- With the second(Qt6), the interface is on point! The buttons do look like actual buttons now. With my 2 LG phones, the buttons still aren't large enough to the point they can be easily selected; though they can very easily be selected on my Samsung phones. Again, this is ONLY on my LG Phones, so it's not a real problem in my opinion, lol (Must have to do with the screen notch for sure).

Morever, the swiping feature you've added is a game changer, as one can just swipe from left to right to easily access the different options. The option are also highlighted when you select or touch them, which is very nice. The screen contents are longer oversized as with the first test build. Here is a link to an unlisted video of me trying to load the files on the second build(qt6), on a LG G7 running android 10. https://youtube.com/shorts/3D1e40x2TSA?feature=share

- P.S. I've done all tests on 3-4 phones, including a galaxy 21+ running android 11, that I've just acquired. As always, just let me know if you have any questions or concerns. I also wanted to add that both test builds install very fast on all my phone (sometimes in just 4-5 seconds!)

Vogtinator commented 3 years ago

Yes, all are above android 8. I don't know how to get the adb log; though if you guided on how to get that log, I'll definitely give it a shot.

You'll have to enable developer mode and run adb logcat on your computer. https://wiki.lineageos.org/adb_fastboot_guide.html might be useful there.

Ok, the first test build gave me some very interesting results. When I did a clean install, it didn't crash, and I was able to load all the files to start the emulation. However, during and upon its completion, everything on its screen was too large, making it unsuable (both portrait and landscape). I've done the test on android 10 and 11 (4 phones in total).

Is it only the screen which is scaled wrongly? Are the buttons and tabs on the configuration page larger than previously?

BTW: The - you used in your comment turn the text directly above into a heading and if there's no next, they start an unordered list. If you want to separate paragraphs, you can use an empty line or <hr/>, the latter looks like:


gastondefer commented 3 years ago

You'll have to enable developer mode and run adb logcat on your computer. https://wiki.lineageos.org/adb_fastboot_guide.html might be useful there.

Ok, I really tried not to screw this one up. I got adb to work , though I'm sure there are better ways of getting the specific line(s)/code(s) you need, that I am simply not aware of. I wasn't quite sure, so I've attached the text file of the logcat. I made sure the app crashes at 11:00, therefore I copied the log record from 10:59 ish till the end.

logcat version 1.5.txt

Is it only the screen which is scaled wrongly? Are the buttons and tabs on the configuration page larger than previously?

Glad you mentioned that, as I'd completely forgot! Yes, the buttons were oversized as well, but I couldn't replicate that effect anymore. I don't quite remember how I ended with oversized buttons in the first place. Perhaps upgrading the app from version 1.4 or 1.5, rather than doing a clean install is what caused it; I really don't know. I even took a picture of he phone right after the installation (S21+ android 11, and S20 ultra android 10). 20210417_142143

BTW: The - you used in your comment turn the text directly above into a heading and if there's no next, they start an unordered list. If you want to separate paragraphs, you can use an empty line or <hr/>, the latter looks like:

I got you. I typed on the phone and totally forgot to remove them.

P.S. I hope I was of a help. Let me know if you need anything else.

adriweb commented 3 years ago

Any news?