search

nspire-emus / firebird

Multi-platform emulator of TI Nspire calculators
GNU General Public License v3.0
665 stars 66 forks source link

Failed to increment internal CFBundleShortVersionString in v1.6 release #311

Open noah978 opened 1 year ago

noah978 commented 1 year ago

Just wanted to leave a note that the internal version in the IPA released with v1.6 was not properly updated from v1.5. As such it can break things (like my auto-updating AltStore Source that pulls from the Github releases).

Thanks!

adriweb commented 1 year ago

Yep I had noticed this but honestly it was too annoying to redo (nothing is automated on this side) for just that change... so, meh :(

Vogtinator commented 1 year ago

Was the IPA built before https://github.com/nspire-emus/firebird/commit/d39ca632004d6963f03a9b1727ba5f936e922afb?

core-code commented 1 year ago

its not just that the version number has not increased, it was completely removed altogether

the previous release had a proper bundle-identifier ( com.adriweb.firebird-emu ) and proper version numbers (1.5) stored in both CFBundleShortVersionString as well as CFBundleVersion

the new release has a changed and generic identifier (com.yourcompany.firebird-emu) and has no version numbers stored in the app at all.

we cannot support updating to the new release in MacUpdater as long as these issues exist.

adriweb commented 1 year ago

Ok I'll check later if I can repackage that. If I have to rebuild it it make take longer, this whole process is made more complex than it should be because qt doesn't solve bugs reported many years ago...

Vogtinator commented 1 year ago

the new release has a changed and generic identifier (com.yourcompany.firebird-emu) and has no version numbers stored in the app at all.

That sounds like Info.plist wasn't used during build at all, it defines all those things correctly...

adriweb commented 1 year ago

Yep, I always have to fiddle with that anyway for some reason, something must have gone wrong this time...