nsporillo / GlobalWarming

Server side global warming mechanics in Minecraft!
GNU Lesser General Public License v3.0
473 stars 46 forks source link

Load WorldClimate Engines #13

Closed dariasc closed 6 years ago

dariasc commented 6 years ago

There is still an issue with FurnaceBurnEvent with one of the Apache Math Calcs

Edit: On closer inspection seems to be an issue with the ScoreTempModel and whenever a furnace ran it would load in the models triggering that bug, it has been commented out so it doesn't affect current testing

dariasc commented 6 years ago

Called the Singleton function from the onEnable() although the loadWorldClimateEngines() is called from the constructor, should we call it from the onEnable() and remove the constructor altogether?

nsporillo commented 6 years ago

Yup, the only thing I would change here is calling the load models method in the main class and like you said remove it from the constructor.