search

nsqio / go-nsq

The official Go package for NSQ
MIT License
2.59k stars 444 forks source link

NewConn requires a delegate #189

Closed isadon closed 8 years ago

isadon commented 8 years ago

Why does NewConn require a delegate interface? I put in nil for the parameter and get a nil pointer dereference crash in go-nsq. Considering that nil can be passed in for an interface I think the documentation for this method should state that its required.

mreiferson commented 8 years ago

There's really no reason to ever use the NewConn interface, it probably shouldn't be exported but that ship has ⛵ .