Closed judwhite closed 6 years ago
this is great, thanks @judwhite!
want to squash down?
Actually, one question β dep
supports libraries, not just binaries?
@mreiferson Yes it does. If you use dep
to import a library which also uses dep
, it reads its Gopkg.toml
to determine which ones you need to resolve. How it deals with conflicts I haven't read about yet, but I know you can override your deps' deps with whatever revision you want.
Squash merge, or do you prefer a merge commit?
squash merge
@mreiferson IIRC you previously/typically had the opposite preference - manual squash then merge commit, over github-squash-merge no-merge-commit?
I misunderstood, since he canβt merge the PR, and I had asked, that he could only be talking about what do do with the commits in this branch.
@mreiferson Squashed.
Use
dep
for dependency management.Two reasons:
dep
is likely the future de-facto community standard (though I'm still a fan ofgovendor
)gpm
doesn't work well with Windows; or Windows doesn't work well withgpm
, take your pick π (see issues)Per the
dep
README:Given this advice, added the following to
.travis.yml
:to replace:
Note
revision = "d9eb7a3d35ec988b8585d4a0068e462c27d28380"
is taken from nsqio/nsq/Godeps#L6. You could also specifybranch = "master"
(orversion = "x.y.z"
if tags exist and you trust semver), which would mimic thego get
command but would differ fromnsqio/nsq
.Added
go 1.9.x
to.travis.yml
.Similar PR coming for
nsqio/nsq
if this approach works.RFR @mreiferson @jehiah @ploxiln